Skip to content

🎨 Improve listing task manager (add filter + and project name, project custom metadata fields) #7661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 13, 2025
Merged

🎨 Improve listing task manager (add filter + and project name, project custom metadata fields) #7661

merged 25 commits into from
May 13, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented May 12, 2025 •
edited
Loading

What do these changes do?

  • 🎨 Add filter_only_running query parameter for /v0/computations/-/iterations/latest listing
  • 🎨 Add rootProjectName and projectCustomMetadata fields in the output model

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 12, 2025
@codecov
Copy link

codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes missing coverage. Please review.

Project coverage is 87.60%. Comparing base (c49b779) to head (cbefa65).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7661      +/-   ##
==========================================
- Coverage   87.71%   87.60%   -0.12%     
==========================================
  Files        1792     1616     -176     
  Lines       69182    65149    -4033     
  Branches     1136      891     -245     
==========================================
- Hits        60682    57072    -3610     
+ Misses       8190     7832     -358     
+ Partials      310      245      -65
Flag Coverage Δ
integrationtests 64.93% <29.72%> (-0.01%) ⬇️
unittests 86.76% <85.45%> (-0.17%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.86% <88.88%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 72.95% <ø> (ø)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.72% <ø> (+0.05%) ⬆️
agent 96.46% <ø> (ø)
api_server 92.50% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 89.88% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.80% <ø> (ø)
director_v2 91.16% <ø> (+0.05%) ⬆️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 88.86% <ø> (-0.17%) ⬇️
storage 87.74% <ø> (+0.17%) ⬆️
webclient ∅ <ø> (∅)
webserver 86.04% <83.78%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c49b779...cbefa65. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: Improve listing task manager 3 🎨 Improve listing task manager 3 May 13, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 13, 2025 09:06
@matusdrobuliak66 matusdrobuliak66 requested a review from odeimaiz May 13, 2025 09:06
odeimaiz
odeimaiz approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 Improve listing task manager 3 🎨 Improve listing task manager (add filter + and project name, project custom metadata fields) May 13, 2025
giancarloromeo
giancarloromeo reviewed May 13, 2025
View reviewed changes
GitHK
GitHK reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sanderegg
sanderegg approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@matusdrobuliak66 matusdrobuliak66 added the 🤖-automerge marks PR as ready to be merged for Mergify label May 13, 2025
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 13, 2025 10:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg disabled auto-merge May 13, 2025 11:57
@sanderegg sanderegg merged commit db71616 into ITISFoundation:master May 13, 2025
94 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the improve-listing-task-manager-3 branch May 13, 2025 12:54
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

🤖-automerge marks PR as ready to be merged for Mergify

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve listing - add filter (filter_only_running) Improve listing: Add the latest project name and node name + root parent name

5 participants

@matusdrobuliak66 @giancarloromeo @GitHK @odeimaiz @sanderegg